jackylee-ch commented on code in PR #1042:
URL: https://github.com/apache/paimon-rust/pull/1042#discussion_r4420096355


##########
crates/paimon/src/table/data_evolution_reader.rs:
##########
@@ -2459,6 +2520,42 @@ fn resolve_field_ids(file: &DataFileMeta, fields: 
&[DataField]) -> crate::Result
     }
 }
 
+/// The key of the vector bunch a vector file joins: its schema, format and
+/// normalized write columns.
+fn vector_bunch_key(
+    file: &DataFileMeta,
+    normalized_write_cols: &[String],
+) -> (i64, String, Vec<String>) {
+    (
+        file.schema_id,
+        vector_format_suffix(&file.file_name),
+        normalized_write_cols.to_vec(),
+    )
+}
+
+/// Whether some VECTOR field is written by files of two vector bunch keys,
+/// such as a rewrite after `ALTER TABLE`; the source plan cannot combine
+/// their bunches.
+fn vector_field_has_two_layouts(files: &[DataFileMeta], infos: 
&[ResolvedFileInfo]) -> bool {
+    let mut layouts = HashMap::new();
+    for (file, info) in files.iter().zip(infos) {
+        let Some(columns) = info
+            .normalized_write_cols
+            .as_deref()
+            .filter(|_| is_vector_store_file_name(&file.file_name))

Review Comment:
   Fixed in 60fcd30: change events merge a row-id group only if the merge reads 
each BLOB or VECTOR column where it is stored; otherwise they decode the group 
file by file. PTAL.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to