sundapeng commented on PR #10351: URL: https://github.com/apache/paimon/pull/10351#issuecomment-6555476740
@JingsongLi all three findings from the 10-26 review are addressed and their threads answered: - `1484678568` gives every FileIO built from options the origin's endpoint under io-cache routing, including the standalone `FileIO.get` behind the URI reader factory (the no-op `origin_only()` is removed), so external row-data/BLOB URIs are read from the origin with routing in the catalog options alone. - `66b450c72c` routes PVFS through the same effective-options merge, so catalog-only policy, targets and origin endpoint are seen when it picks the origin. - `52fb0b9c86` keeps the vended token in the shared cache unmodified and applies each catalog's `io-cache.enabled` / `dlf.oss-endpoint` override per instance, in Python, the native data token and Daft alike. I also checked the same class on the other two PRs: the Java token-scoped FileIO cache is fixed in #10350 (`84363ffb61`), and the Rust client already merges the catalog options with the token per instance, so no change was needed there. `4b1bd71b98` is the current head (it also keeps the native REST fallback on the origin); CI is green there. Could you take another look when you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
