JingsongLi commented on PR #10910: URL: https://github.com/apache/paimon/pull/10910#issuecomment-6556753797
The fixture change is technically sound: constructing the string through `file.toUri()` and Paimon's `Path.toString()` preserves the unescaped space/Unicode test case while avoiding native Windows path concatenation. I ran the complete `UriReaderFactoryTest` on JDK 8/macOS with normal Maven `verify`: all 15 cases pass, including Checkstyle, Spotless, Enforcer and RAT. CI is green. I did not independently run Windows. This PR changes only how one test constructs its input. `UriReaderFactory`, `FileUriReader`, their accepted inputs, and production read behavior are unchanged. The repository's current Java CI runs on Ubuntu, so this also does not repair the current production verification gate. The demonstrated benefit is Windows test-fixture portability, rather than an end-to-end table/engine or deployed workload change. Closing this standalone PR under the current end-to-end contribution scope. The portability cleanup can accompany a concrete supported-platform or functional change with its corresponding end-to-end verification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
