JingsongLi commented on PR #10890: URL: https://github.com/apache/paimon/pull/10890#issuecomment-6557442306
Reviewed the complete diff and the production ownership chain. This correctly closes the stream owned by `FileBasedBloomFilterTest`, while preserving the filter/cache invalidation assertions. Production `FileBasedBloomFilter.close()` intentionally only invalidates its shared-cache entry; the owning `SortLookupStoreReader` already closes its input, including the exception path. Consequently this PR changes standalone Windows test cleanup, rather than a deployed resource leak or an observed failure in the current Ubuntu CI. For this review batch we are requiring an end-to-end production or current CI outcome. I ran the complete FileBasedBloomFilterTest under JDK 8 with the normal Maven verify checks: all 8 unique cases passed; current PR CI is green. Windows was not independently rerun here. Closing this standalone test-portability change under that scope. A follow-up can connect it to a supported CI job or a demonstrated production ownership failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
