lucasfang opened a new issue, #488:
URL: https://github.com/apache/paimon-cpp/issues/488

   ## Search before asking
   
   - [x] I searched in the 
[issues](https://github.com/apache/paimon-cpp/issues) and found nothing similar.
   
   ## Paimon-cpp version
   
   main (dbe5dc9b)
   
   ## Minimal reproduce step
   
   1. Run `test/generate_coverage.sh`.
   2. Open `build/coverage/index.html`.
   
   ## What doesn't meet your expectations?
   
   `lcov --capture` collects every file recorded in the `.gcno` data, so the 
report contains:
   
   - System headers under `/usr/include/c++/...` and `/usr/lib/gcc/...` (~39k 
files locally).
   - Third-party headers installed into the build tree by ExternalProject 
(`arrow_ep-install/`, `boost_ep-install/`, `googletest_ep-install/`, 
`fmt_ep-install/`, etc., ~10k files).
   - Sources under `third_party/`.
   - Test sources (`*_test.cpp`, `src/paimon/testing/`, mocks).
   
   This floods the directory view with irrelevant entries and dilutes the 
overall coverage rate to a meaningless number, making it hard to review the 
actual coverage of `src/paimon` and `include/paimon`.
   
   Additionally, the script's cmake invocation does not enable the optional 
file formats (MOSAIC, LANCE, VORTEX are OFF by default), so their code is 
silently missing from the report.
   
   Expected: the report only covers project implementation code, with all file 
formats enabled.
   
   ## Anything else?
   
   Locally, adding an `lcov --remove` filter step drops the report from ~58k 
files to ~17k and yields 93.1% line / 92.3% function coverage on a full `ctest` 
run.
   
   ## Are you willing to submit a PR?
   
   - [x] I'm willing to submit a PR!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to