SteNicholas commented on code in PR #487:
URL: https://github.com/apache/paimon-cpp/pull/487#discussion_r4440159257


##########
src/paimon/core/table/table.cpp:
##########
@@ -28,6 +28,7 @@
 #include <vector>
 
 #include "arrow/c/bridge.h"
+#include "arrow/compute/initialize.h"

Review Comment:
   [P1] Guard initialization for the bundled Arrow version
   
   The standard build pins Arrow 17.0.0 in `third_party/versions.txt`, which 
provides neither `arrow/compute/initialize.h` nor 
`arrow::compute::Initialize()`. `cmake_modules/arrow.diff` does not backport 
them, so this unconditional include breaks compilation with the repository's 
bundled dependency. Please guard both the include and the initialization call 
for Arrow versions that provide this API. Arrow 17 already registers the 
compute kernels when constructing its [global function 
registry](https://github.com/apache/arrow/blob/apache-arrow-17.0.0/cpp/src/arrow/compute/registry.cc),
 with `ARROW_COMPUTE=ON` as configured here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to