JeonDaehong commented on code in PR #1267:
URL: https://github.com/apache/paimon-rust/pull/1267#discussion_r4443557518
##########
crates/paimon/src/io/cache/mod.rs:
##########
@@ -84,6 +85,7 @@ impl LocalCache {
block_size,
whitelist: FileType::parse_whitelist(whitelist),
file_size_capacity: DEFAULT_FILE_SIZE_CAPACITY,
+ excluded_extensions: HashSet::new(),
Review Comment:
`with_file_block_cache` has no way to pass exclusions, so an external cache
(also what the C binding uses) always caches BLOB files even when
`local-cache.exclude-extensions` is set. Is that intended, or should it take
the exclusions too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
