LuciferYang opened a new pull request, #10954:
URL: https://github.com/apache/paimon/pull/10954

   ### Purpose
   
   close #10953
   
   A filesystem-managed commit checks its lease before 
`RenamingSnapshotCommit.commitImpl`, which then asks the file system whether 
the new snapshot file exists before it publishes. On an object store that 
request can outlast the lease, and the snapshot was still published.
   
   `commitImpl` now checks the lease again after the existence check, before 
`tryToWriteAtomic`. A slow write inside `tryToWriteAtomic` can still outlast 
the lease; this only removes the extra request between the check and the write. 
The LATEST hint written after a successful publish is unchanged: the snapshot 
is already committed at that point, and a stale hint is corrected when the 
latest snapshot is looked up.
   
   ### Tests
   
   `RenamingSnapshotCommitTest#testCommitRechecksLeaseAfterCheckingSnapshot`: 
the lease expires while the commit checks whether snapshot 5 exists. The commit 
fails with the lease error and snapshot 5 is not written. On master the commit 
succeeds and writes snapshot 5.
   
   ### API and Format
   
   no
   
   ### Documentation
   
   no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to