slfan1989 commented on code in PR #1271:
URL: https://github.com/apache/paimon-rust/pull/1271#discussion_r4439201164
##########
crates/integrations/datafusion/src/merge_into.rs:
##########
@@ -1538,15 +1538,20 @@ async fn build_source_partition_set(
ctx: &SQLContext,
table: &Table,
source_ref: &str,
- s_alias: &str,
- t_alias: &str,
+ s_alias: &Ident,
+ t_alias: &Ident,
on_expr: &SqlExpr,
) -> DFResult<Option<HashSet<Vec<u8>>>> {
let partition_keys = table.schema().partition_keys();
if partition_keys.is_empty() {
return Ok(None);
}
- if !can_prune_target_by_source_partitions(partition_keys, t_alias,
s_alias, on_expr) {
+ if !can_prune_target_by_source_partitions(
+ partition_keys,
+ &t_alias.value,
Review Comment:
Thanks for the review! I’ll preserve `Ident` in the partition-pruning
checks, follow DataFusion’s identifier rules, and add a regression test for
case-sensitive aliases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]