fastio opened a new pull request, #498:
URL: https://github.com/apache/paimon-cpp/pull/498

   ### Purpose
   
   Linked issue: close #497
   
   `FilesSystemTable` and `ManifestsSystemTable` always read the latest 
snapshot, even when the
   caller sets `scan.snapshot-id`. A reader that pins a snapshot therefore gets 
file and manifest
   metadata from a newer commit, and a snapshot id that does not exist silently 
falls back to the
   latest snapshot.
   
   This change replaces `LatestSnapshot()` with `SelectedSnapshot()`, which 
reads
   `CoreOptions::GetScanSnapshotId()`:
   
   - unset: the latest snapshot, as before;
   - set and present: that snapshot;
   - set but missing: `Status::NotExist("snapshot <id> does not exist")` 
instead of a fallback.
   
   `ReadLatestManifestEntries` / `ReadLatestDataFiles` are renamed to
   `ReadSelectedManifestEntries` / `ReadSelectedDataFiles` to match. 
`ManifestsSystemTable` now
   builds `CoreOptions` before selecting the snapshot.
   
   Other time travel options (`scan.tag-name`, `scan.timestamp-millis`, ...) 
are out of scope.
   Tables that list history (`$snapshots`, `$schemas`, `$tags`, ...) are 
unchanged.
   
   ### Tests
   
   - `SystemTableReadInteTest.TestReadMetadataSystemTablesAtPinnedSnapshot`: 
commits two
     snapshots to a primary-key table, then checks that
     - without the option, `$files` returns both files;
     - with `scan.snapshot-id = 1`, `$files` returns only the first file 
(`record_count = 1`) and
       `$manifests` returns fewer manifests than the latest snapshot;
     - with `scan.snapshot-id = 3`, both tables fail with `snapshot 3 does not 
exist`.
   
   Verified on Ubuntu 24.04 (aarch64), GCC 13, Debug: `paimon-read-inte-test` 
passes (303 tests),
   including the 31 `SystemTableReadInteTest` cases.
   
   ### API and Format
   
   No public API change (only an internal file under `src/`). No storage format 
or protocol change.
   
   ### Documentation
   
   No.
   
   ### Generative AI tooling
   
   Generated-by: Claude Code (Claude Opus 5.5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to