lxy-9602 commented on code in PR #499:
URL: https://github.com/apache/paimon-cpp/pull/499#discussion_r4463063340


##########
src/paimon/core/table/table.cpp:
##########
@@ -871,9 +871,12 @@ Result<std::unique_ptr<TableScan>> NewDataTableScan(
         ValidateRealtimeScan(*table_schema, core_options, *context, 
read_optimized));
     // validate options
     if (core_options.GetBucket() == -1) {
-        if (!table_schema->PrimaryKeys().empty()) {
-            return Status::NotImplemented(fmt::format(
-                "do not support pk table bucket={} in scan process", 
core_options.GetBucket()));
+        // Batch planning of dynamic bucket primary key tables only depends on 
the buckets
+        // recorded in the manifest, and deletion vectors are looked up per 
(partition, bucket).
+        if (!table_schema->PrimaryKeys().empty() && 
context->IsStreamingMode()) {
+            return Status::NotImplemented(
+                fmt::format("do not support pk table bucket={} in streaming 
scan process",
+                            core_options.GetBucket()));

Review Comment:
   Could we also add an integration test for the case without DV but requiring 
MOR? Since the DV switch on/off seems to be orthogonal to dynamic buckets.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to