JingsongLi commented on PR #94:
URL: 
https://github.com/apache/paimon-vector-index/pull/94#issuecomment-6677946119

   Requirement fit: SUPPORTED. Implementation: CLEAN at `d04cb46`.
   
   The bounded scratch has concrete end-to-end value: current main still 
materializes full f32 sections, and a 65,536 × 768 coarse-centroid matrix alone 
needs a 192 MiB byte copy. The new writer preserves section order, 
little-endian bits and write-error propagation while reusing at most 64 MiB of 
float-serialization scratch.
   
   Verified in isolated worktrees: 511 workspace tests passed on this head; 689 
passed after mechanically adapting the merge to current main `f80e556`; golden 
storage fixtures, fmt and strict Clippy passed. An additional reviewer test 
passed for 0/1/3/7/64-byte limits, signed zero/NaN bit preservation and an 
injected second-write failure.
   
   Before merging, please rebase: this head conflicts in `core/src/io.rs` 
because current main uses `index.pq.centroids()`. The local integration test 
retained the new buffered call and used that accessor. Please apply the 
equivalent update and rerun CI on the rebased head. No additional 
implementation finding.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to