zhouyc-ali commented on code in PR #471:
URL: https://github.com/apache/paimon-cpp/pull/471#discussion_r4465894401
##########
src/paimon/format/vortex/vortex_file_format.cpp:
##########
@@ -29,7 +31,33 @@ namespace paimon::vortex {
Result<std::unique_ptr<ReaderBuilder>> VortexFileFormat::CreateReaderBuilder(
int32_t batch_size) const {
- return std::make_unique<VortexReaderBuilder>(batch_size);
+ VortexPredicateOptions predicate_options;
+ const auto membership_mode =
options_.find("vortex.read.membership-pushdown");
+ if (membership_mode != options_.end()) {
Review Comment:
Centralized option definitions in `vortex_defs.h` and made argument order
consistent, with the pool last.
##########
test/inte/scan_and_read_inte_test.cpp:
##########
@@ -3727,6 +3727,233 @@ TEST_F(ScanAndReadInteTest,
TestMosaicJavaAndPythonCompatibility) {
#endif
#ifdef PAIMON_ENABLE_VORTEX
+namespace {
+
+Result<std::shared_ptr<arrow::ChunkedArray>> ReadVortexSdkRows(
+ const std::string& table_path, const std::vector<std::shared_ptr<Split>>&
splits,
+ const std::vector<std::string>& projection, const
std::shared_ptr<Predicate>& predicate,
+ bool exact_filter, bool late_materializing) {
+ ReadContextBuilder builder(table_path);
+ builder.SetReadFieldNames(projection)
+ .SetPredicate(predicate)
+ .EnablePredicateFilter(exact_filter)
+ .EnableLateMaterializing(late_materializing)
+ .EnablePrefetch(true)
+ .SetPrefetchBatchCount(2)
+ .SetPrefetchMaxParallelNum(2)
+ .AddOption(Options::READ_BATCH_SIZE, "2");
Review Comment:
Vortex does not use framework prefetch; removed those test settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]