JingsongLi commented on code in PR #10971:
URL: https://github.com/apache/paimon/pull/10971#discussion_r4456141381
##########
paimon-python/pypaimon/read/table_read.py:
##########
@@ -518,12 +518,6 @@ def to_torch(
):
raise ValueError("batch_size must be a positive int or None")
if batch_format == "row":
Review Comment:
[P2] Update the existing VARIANT Torch boundary regression
Removing this guard changes the exception on a map-style request with Native
reading disabled, but
`TestVariantPaimonTable.test_variant_projection_torch_row_backend_boundary` in
`pypaimon/tests/variant_test.py:1300` still asserts `Torch row format`. Running
that exact test on this head fails because the message is now `Variant
extraction requires a compatible native reader: read.native.enabled is false`.
The same missed assertion is present in the failed Python 3.10/3.11/3.12/3.13
and Native CI runs, so the PR cannot pass its required suite despite the new
tests succeeding. Please update that existing test to the new
disabled/missing-runtime contract and include it in validation, retaining
coverage of append and Data Evolution tables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]