q8webmaster commented on PR #125:
URL: https://github.com/apache/paimon-trino/pull/125#issuecomment-6737633234

   The deletion-vector bug from #129 is also in this branch. 
`TrinoPageSourceWrapper#getNextSourcePage()` still uses 
`getCompletedPositions()` as the page's start position. When a pushed-down 
filter makes the ORC reader skip row groups, filtered reads of ORC files with 
deletion vectors return wrong rows.
   
   The fix in #130 targets `main`, but it also applies cleanly to this branch. 
I can open it as a PR against your branch if that's easier. Whichever PR merges 
first, the other only needs a small rebase in `TrinoPageSourceWrapper`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to