SteNicholas commented on code in PR #538:
URL: https://github.com/apache/paimon-cpp/pull/538#discussion_r4518803628


##########
.github/workflows/build_and_test.yaml:
##########
@@ -43,13 +43,96 @@ jobs:
       - name: Run CMake module tests
         shell: bash
         run: ci/scripts/test_cmake_modules.sh
+      - name: Test release asset downloads
+        shell: bash
+        run: bash ci/scripts/test_download_release_asset.sh
       - name: Run packaging argument tests
         shell: bash
         run: ci/scripts/test_packaging_args.sh
       - name: Run asan_symbolize tests
         shell: bash
         run: ci/scripts/test_asan_symbolize.sh
 
+  macos-build-and-test:
+    name: ${{ matrix.name }}
+    runs-on: macos-15
+    timeout-minutes: 180
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - name: appleclang-release-arm64
+            cc: /usr/bin/clang
+            cxx: /usr/bin/clang++
+            build_type: Release
+          - name: appleclang-debug-arm64
+            cc: /usr/bin/clang
+            cxx: /usr/bin/clang++
+            build_type: Debug
+          - name: gcc15-release-macos-arm64
+            cc: /opt/homebrew/bin/gcc-15
+            cxx: /opt/homebrew/bin/g++-15
+            build_type: Release
+            gcc_formula: gcc@15
+    env:
+      CC: ${{ matrix.cc }}
+      CXX: ${{ matrix.cxx }}
+      PAIMON_BUILD_JOBS: '3'
+      CARGO_BUILD_JOBS: '3'
+    steps:
+      - name: Checkout paimon-cpp
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # 
v6.0.1
+        with:
+          lfs: true
+      - name: Install build dependencies
+        shell: bash
+        run: |
+          brew install cmake ninja protobuf openssl@3 curl
+          echo "$(brew --prefix protobuf)/bin" >> "$GITHUB_PATH"
+          echo "CMAKE_PREFIX_PATH=$(brew --prefix openssl@3):$(brew --prefix 
curl)" >> "$GITHUB_ENV"
+      - name: Install GCC
+        if: matrix.gcc_formula
+        shell: bash
+        env:
+          GCC_FORMULA: ${{ matrix.gcc_formula }}
+        run: brew install "${GCC_FORMULA}"
+      - name: Show compiler versions
+        shell: bash
+        run: |
+          "${CC}" --version
+          "${CXX}" --version
+      - name: Setup ccache
+        uses: ./.github/actions/setup-ccache
+        with:
+          cache-key-prefix: ccache-${{ matrix.name }}
+      - name: Prepare release assets
+        uses: ./.github/actions/setup-release-assets
+      - name: Install Rust and protobuf tools
+        shell: bash
+        run: ci/scripts/setup_rust.sh
+      - name: Install flatc and libclang (Vortex)
+        shell: bash
+        run: ci/scripts/setup_flatc.sh
+      - name: Build, test and verify installation
+        shell: bash
+        run: |
+          ci/scripts/build_paimon.sh \
+            --source_dir "$(pwd)" \
+            --build_type "${{ matrix.build_type }}" \
+            --install_smoke

Review Comment:
   **All three new macOS jobs fail before reaching CTest or the installation 
smoke test.** In [the current 
run](https://github.com/apache/paimon-cpp/actions/runs/42593494587/job/129080686539),
 compilation of `paimon_file_index_objlib` fails with `fmt/format.h` not found. 
Configuration selects system fmt, but that object target does not receive its 
include directory: `add_paimon_lib()` applies `STATIC_LINK_LIBS` to the final 
libraries, and the internal `paimon_shared` dependency does not propagate 
compile usage requirements to this object target. Please wire fmt's usage 
requirements into the object-library compilation, or explicitly select bundled 
fmt for these jobs, and verify that the actual macOS matrix reaches its tests.



##########
.github/workflows/build_and_test.yaml:
##########
@@ -43,13 +43,96 @@ jobs:
       - name: Run CMake module tests
         shell: bash
         run: ci/scripts/test_cmake_modules.sh
+      - name: Test release asset downloads
+        shell: bash
+        run: bash ci/scripts/test_download_release_asset.sh
       - name: Run packaging argument tests
         shell: bash
         run: ci/scripts/test_packaging_args.sh
       - name: Run asan_symbolize tests
         shell: bash
         run: ci/scripts/test_asan_symbolize.sh
 
+  macos-build-and-test:
+    name: ${{ matrix.name }}
+    runs-on: macos-15
+    timeout-minutes: 180
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - name: appleclang-release-arm64
+            cc: /usr/bin/clang
+            cxx: /usr/bin/clang++
+            build_type: Release
+          - name: appleclang-debug-arm64
+            cc: /usr/bin/clang
+            cxx: /usr/bin/clang++
+            build_type: Debug
+          - name: gcc15-release-macos-arm64
+            cc: /opt/homebrew/bin/gcc-15
+            cxx: /opt/homebrew/bin/g++-15

Review Comment:
   **The GCC macOS entry also needs C++ dependencies built against GCC's 
standard library.** Dependency resolution remains `AUTO`, and [this job's 
configure 
log](https://github.com/apache/paimon-cpp/actions/runs/42593494587/job/129080686550)
 already selects Homebrew's system fmt. That library uses libc++, whereas 
`g++-15` uses libstdc++. After supplying the include path, a minimal 
`fmt::format("value={}", 42)` program reproduces a link failure for 
`fmt::v12::vformat[abi:cxx11]` with GCC; the same program links with 
AppleClang. Thus fixing the missing header alone still leaves this entry unable 
to link. Please explicitly build fmt, and any other selected C++ binary 
dependencies, with the selected GCC toolchain rather than consuming 
incompatible Homebrew bottles.



##########
.github/workflows/build_and_test.yaml:
##########
@@ -88,6 +171,12 @@ jobs:
             cc: gcc-14
             cxx: g++-14
             build_args: --build_type Release
+          - name: gcc13-release-aarch64
+            runner: ubuntu-24.04-arm
+            cc: gcc-13
+            cxx: g++-13
+            gcc_version: '13.3.0'
+            build_args: --build_type Release

Review Comment:
   **The GCC 13.3 ARM64 regression job still cannot compile the current head.** 
[Its build 
log](https://github.com/apache/paimon-cpp/actions/runs/42593494587/job/129080687086)
 fails in `src/paimon/rest/rest_token_file_system_test.cpp:638` at 
`std::optional<std::shared_ptr<FileSystem>> cached = 
cache->GetIfPresent(token);`, with the same `-Werror=maybe-uninitialized` 
diagnostic on the shared-pointer payload. This configuration enables REST, so 
the optional-initialization fixes in the realtime-store and deletion-vector 
code leave another build blocker before CTest can run. Please include this 
remaining initialization in the workaround and rerun the actual GCC 13.3.0 
ARM64 Release job with strict warnings retained.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to