SteNicholas commented on code in PR #539:
URL: https://github.com/apache/paimon-cpp/pull/539#discussion_r4520605927


##########
cmake_modules/oss_sdk_v2.diff:
##########
@@ -0,0 +1,11 @@
+diff --git a/sdk/src/internal/ClientImplBase.cpp 
b/sdk/src/internal/ClientImplBase.cpp

Review Comment:
   **Account for this new patch in the RAT license check.** This file has no 
recognized license header, and `.github/.rat-excludes` only exempts the 
existing `arrow.diff`, `jieba.diff`, `orc.diff`, and `vortex.diff` patches. On 
`68be088b`, 
[rat-license-check](https://github.com/apache/paimon-cpp/actions/runs/42744545604/job/129593408441)
 fails with `1 Unknown Licenses` and lists `./cmake_modules/oss_sdk_v2.diff` as 
the sole unapproved file, so this addition makes the license gate fail. Please 
add an appropriate license header or extend `.github/.rat-excludes` 
consistently with the existing third-party patch files, then rerun the license 
check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to