JunRuiLee commented on code in PR #11048:
URL: https://github.com/apache/paimon/pull/11048#discussion_r4521270202


##########
paimon-python/pypaimon/execution/python/write/commit/row_id_conflict.py:
##########
@@ -35,10 +35,9 @@ def check_row_id_conflicts(table, messages, 
latest_snapshot_id, check_from_snaps
     baseline = manager.get_snapshot_by_id(check_from_snapshot)
     if latest is None or baseline is None:
         raise ValueError('Row-ID conflict check snapshots must exist in the 
current table')
-    current_schema = table.schema_manager.latest()
-    if (baseline.schema_id != latest.schema_id
-            or current_schema is not None and current_schema.id != 
table.table_schema.id):
-        raise ValueError('Row-ID conflict checks require an unchanged, current 
table schema')
+    # Logical conflicts compare field IDs resolved in each file's historical
+    # schema, just like ordinary commits. Different schema versions alone do

Review Comment:
   Thanks for the reproduction. I confirmed the same behavior with both the 
current coordinator and the pre-PR self-merge coordinator from `4b8e50df3178`, 
using the same native runtime: one native commit call publishes with schema 0 
and then schema 1, the CAS results are `false -> true`, and `age` reads back as 
`[NULL, 12]`.
   
   The issue is real, but it also occurs on the pre-PR commit path, and this PR 
does not change the native commit bridge. The validation needs to run inside 
Rust's snapshot preparation/retry loop; the current Python binding has no 
pre-publication hook for each native attempt (commit callbacks run after 
successful publication). I’m therefore keeping this Native REST retry issue 
outside this PR’s scope. It should be addressed separately in `paimon-rust`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to