lyne7-sc opened a new pull request, #1366:
URL: https://github.com/apache/paimon-rust/pull/1366

   <!--
   Thank you very much for contributing to Paimon Rust - we are happy that you 
want to help us improve it. To help the community review your contribution in 
the best possible way, please go through the checklist below, which will get 
the contribution into a shape in which it can be best reviewed.
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GitHub 
issue](https://github.com/apache/paimon-rust/issues). Exceptions are made for 
typos in documentation or comments, which need no issue.
   
     - Fill out the template below to describe the changes contributed by the 
pull request. That will give reviewers the context they need to do the review.
   
     - Make sure that the change passes the automated tests, i.e., `cargo test` 
passes.
   
     - Each pull request should address only one issue, not mix up code from 
multiple issues.
   
   **(The sections below can be removed for hotfixes or typos)**
   -->
   
   ### Purpose
   
   <!-- Linking this pull request to the issue -->
   Linked issue: close #1365
   
   <!-- What is the purpose of the change -->
   
   Key-value buffer flushes only roll by row count and ignore 
`target-file-size`. Use the existing rolling writer for data and input 
changelog files so flushes also follow its size and memory rolling policy.
   
   ### Brief change log
   
   <!-- Please describe the changes made in this pull request and explain how 
they address the issue -->
   
   - Route bounded output chunks through `KeyValueRollingWriter`, respecting 
the remaining row capacity.
   - Preserve file numbering across flushes and abort the rolling writer if 
writing fails.
   
   ### Tests
   
   <!-- List unit tests or integration cases to verify this change -->
   
   - `target_file_size_rolls_flush_data_and_changelog` checks size-triggered 
rolling, file numbering and readback across two flushes. 
   - `target_file_row_num_rolls_data_and_changelog_with_local_metadata` checks 
row limits and per-file metadata. New tests also cover remaining row capacity 
and empty output.
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   
   No public API or storage format changes. Output file boundaries can change; 
`target-file-size` remains a rolling target, not a strict cap.
   
   ### Documentation
   
   <!-- Does this change introduce a new feature or require documentation 
updates -->
   
   No documentation changes. This restores the existing rolling policy on the 
buffer-flush path.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to