JingsongLi commented on code in PR #11040:
URL: https://github.com/apache/paimon/pull/11040#discussion_r4522784934


##########
paimon-core/src/main/java/org/apache/paimon/table/source/AbstractDataTableScan.java:
##########
@@ -550,7 +554,7 @@ protected StartingScanner createStartingScanner(boolean 
isStreaming) {
                         snapshotManager,
                         changelogManager,
                         creationTimeMills,
-                        options.changelogLifecycleDecoupled(),
+                        readRetainedChangelog(),

Review Comment:
   **[P2] Include the oldest retained changelog at an equal creation timestamp**
   
   I reproduced this with a coupled PK table, four successive updates to one 
key and a one-off expiration retaining snapshot 4 and changelogs 1–3. Starting 
with `scan.creation-time-millis` equal to changelog 1's timestamp emits only 
the current value `4` and advances to checkpoint 5. Setting the timestamp to 
changelog 2's timestamp emits `2, 3, 4`, and ordinary timestamp startup at 
changelog 1 emits `1, 2, 3, 4`.
   
   `FROM_CREATION_TIMESTAMP` documents snapshot startup for the 
earliest-to-latest interval. The `>=` guard in 
`TimeTravelUtil.earlierThanTimeMills` returns null on equality and selects a 
current-snapshot file-creation scan instead. Could equality return the earliest 
ID minus one, reserving the file-creation fallback for a strictly older 
timestamp?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to