wwj6591812 commented on code in PR #10922:
URL: https://github.com/apache/paimon/pull/10922#discussion_r4531360591
##########
paimon-format/src/main/java/org/apache/paimon/format/blob/AbstractBlobElementWriter.java:
##########
@@ -115,15 +122,23 @@ protected final long writePlaceholderElement() {
}
protected final BlobFetchResult getBlob(BlobGetter getter) {
+ if (transferMetricsEnabled) {
+ transferStartNanos = System.nanoTime();
Review Comment:
Thanks, @JingsongLi, for the clear FILE → CUSTOM → FILE reproduction and for
catching this attribution bug.
The writer now excludes only the time spent closing the previous reused
source from the current payload's latency. The current source's open, seek
(including a same-source rewind), and copy remain inside the timed interval.
Cleanup exceptions retain their existing propagation behavior, and the
metrics-disabled path does not add clock reads.
I added two real-writer regressions with payload readback: the FILE →
slow-closing CUSTOM → FILE case, and a case that keeps the current
open/seek/read time in the sample. The first regression fails against the
previous PR head and passes with the fix. The JDK 8 BLOB test selection passed
all 150 tests, including source reuse, failure handling, and table-level option
coverage.
Addressed in c75ea4c956fe34019203ce34d9c2df8cc05718f7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]