danzhewuju commented on code in PR #11067:
URL: https://github.com/apache/paimon/pull/11067#discussion_r4532894679
##########
paimon-common/src/main/java/org/apache/paimon/predicate/RowIdPredicateVisitor.java:
##########
@@ -56,11 +56,16 @@ public Optional<List<Range>> visit(LeafPredicate predicate)
{
if (function instanceof Equal || function instanceof In) {
ArrayList<Long> rowIds = new ArrayList<>();
for (Object literal : predicate.literals()) {
- rowIds.add((Long) literal);
+ if (literal != null) {
+ rowIds.add((Long) literal);
+ }
}
return Optional.of(Range.toRanges(rowIds));
} else if (function instanceof Between) {
List<Object> literals = predicate.literals();
+ if (literals.contains(null)) {
Review Comment:
Thanks for catching this! I’ve updated it to check the two bounds directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]