JingsongLi commented on PR #1364:
URL: https://github.com/apache/paimon-rust/pull/1364#issuecomment-6784482985
Requirement fit: SUPPORTED. The missing binding documentation is useful, but
the new tag-management walkthrough is not executable as presented.
**[P2] Separate filesystem tag operations from REST-only
pagination/rollback, and keep the rollback tag alive**
(`docs/src/python-binding.md:566-571`). The guide's filesystem `PaimonCatalog`
supports create/get/delete tags, but `list_tags_paged` and `rollback_to`
inherit the core defaults that return `Unsupported` (mapped to
`NotImplementedError` by the Python binding). A reader following this example
therefore stops at `list_tags_paged`. With a REST catalog that implements those
operations, the example deletes `release-1.0` before attempting
`Instant.tag("release-1.0")`, so that rollback has no tag to resolve. Please
state the REST/server support requirement, separate the optional REST example,
and move deletion after the rollback example (or recreate the tag).
Validation: `mkdocs build --strict --config-file docs/mkdocs.yml` passed. I
cross-checked the added calls against the Python exports and
`Catalog`/`FileSystemCatalog` implementations; the documentation build does not
execute these Python snippets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]