ljyss9 commented on code in PR #483:
URL: https://github.com/apache/paimon-cpp/pull/483#discussion_r4534805825
##########
src/paimon/indexer/lumina/lumina_index_searcher.cpp:
##########
@@ -89,30 +90,30 @@ Result<::lumina::api::LuminaSearcher::SearchResult>
LuminaIndexSearcher::Search(
if (!vector_search->pre_filter) {
PAIMON_ASSIGN_OR_RAISE_FROM_LUMINA(
::lumina::api::LuminaSearcher::SearchResult search_result,
- searcher_with_tag_->SearchWithTag(query, tag_filter,
search_options, *pool_));
+ searcher_with_tag_->SearchWithTag(query, tag_filter,
search_options, session_pool));
Review Comment:
Cached reader data uses an independently owned pool, and every
`LuminaIndexSearcher::Search` creates `LuminaMemoryPool
session_pool(GetMemoryPool())` for its temporary allocations. Search
allocations therefore do not use the first query's pool or the cached reader's
pool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]