PyRSA commented on code in PR #11031:
URL: https://github.com/apache/paimon/pull/11031#discussion_r4535014122


##########
paimon-python/pypaimon/execution/python/read/reader/aggregate/aggregators.py:
##########
@@ -1240,8 +1263,19 @@ def _resolve_ts_field_index(self, row_type: RowType, 
options: CoreOptions, field
                     )
                 )
 
+        ts_type = row_type.fields[ts_field_index].type
+        ts_base = _atomic_base_name(ts_type)
+        if ts_base not in _KEYTIME_TIMESTAMP_TYPES:

Review Comment:
   Thanks for pointing this out! I've fixed the nanosecond precision loss in 
the record batch reader and added regression tests covering the public table 
read path for TIMESTAMP(9) and TIMESTAMP_LTZ(9).



##########
paimon-python/pypaimon/execution/python/read/reader/aggregate/aggregators.py:
##########
@@ -1240,8 +1263,19 @@ def _resolve_ts_field_index(self, row_type: RowType, 
options: CoreOptions, field
                     )
                 )
 
+        ts_type = row_type.fields[ts_field_index].type
+        ts_base = _atomic_base_name(ts_type)
+        if ts_base not in _KEYTIME_TIMESTAMP_TYPES:

Review Comment:
   Thanks for pointing this out! I've fixed the nanosecond precision loss in 
the record batch reader and added regression tests covering the public table 
read path for TIMESTAMP(9) and TIMESTAMP_LTZ(9).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to