junmuz commented on code in PR #11072:
URL: https://github.com/apache/paimon/pull/11072#discussion_r4540392703
##########
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java:
##########
@@ -1675,17 +1675,25 @@ public boolean replaceManifestList(
@Nullable String indexManifest,
@Nullable Long nextRowId,
@Nullable Map<String, String> properties) {
- return replaceManifestListOnce(
- latest,
- totalRecordCount,
- baseManifestList,
- deltaManifestList,
- indexManifest,
- nextRowId,
- properties);
+ Snapshot snapshot =
+ replaceManifestListOnce(
+ latest,
+ totalRecordCount,
+ baseManifestList,
+ deltaManifestList,
+ indexManifest,
+ nextRowId,
+ properties);
+ if (snapshot == null) {
+ return false;
+ }
+ // Like regular commits, run post-commit callbacks after releasing the
commit lock.
+ commitCallbacks.forEach(callback ->
callback.onManifestReplacement(snapshot));
Review Comment:
Addressed. Repairs now persist a snapshot marker. Rerunning
remove_unexisting_manifests replays callbacks using the committed repair’s user
without reating another snapshot. Added tests that inject metadata-write and
catalog-publication failures, reload the table, and retry through the repair
procedure. All four recovery cases pass, covering both present and missing
predecessor metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]