lxy-9602 opened a new pull request, #552:
URL: https://github.com/apache/paimon-cpp/pull/552

   <!-- PR titles must follow Conventional Commits: <type>(<optional-scope>): 
<description> -->
   
   ### Purpose
   
   <!-- Linking this pull request to the issue -->
   Linked issue: close #551 .
   
   Global index bitmap results retain suppliers and their captured objects 
until first access. Merging multiple results through repeated pairwise OR 
operations also repeatedly copies growing intermediate bitmaps.
   
   This change:
   - Computes bitmap results during creation and propagates supplier errors 
immediately, allowing results to outlive their readers without retaining them.
   - Adds a shared `UnionResults` helper that uses `FastUnion` for bitmap 
results across sorted-file readers, union readers, and OR predicate evaluation. 
Other result types retain their virtual Or behavior.
   - Computes bitmap intersections by copying the operand with the smaller 
storage size and applying `&=`, avoiding an extra result copy.
   
   Existing handling of unavailable index results, predicate field tracking, 
and scored-result semantics is preserved.
   
   <!-- What is the purpose of the change -->
   
   ### Tests
   Added or updated coverage for:
   - Immediate supplier execution, error propagation, and release of captured 
objects.
   - Result validity after reader closure and destruction.
   - AND, OR, and offset results remaining valid after their operands are 
released.
   - Batch unions with empty, single, overlapping, and 64-bit row-id inputs.
   - Scored and mixed-result unions, including duplicate-row validation.
   <!--
   Describe tests added or updated and what they cover; explain if no test 
changes are needed.
   Omit execution commands, results, and reasons tests were not run locally.
   -->
   
   ### API and Format
   The public `BitmapGlobalIndexResult` constructor now accepts a 
`RoaringBitmap64`. Supplier-based callers use 
`BitmapGlobalIndexResult::Create()`, which executes the supplier immediately 
and returns any error.
   
   No storage format or protocol changes.
   
   <!-- Does this change affect API in include dir or storage format or 
protocol -->
   
   ### Documentation
   Updated public API comments to describe result creation and bitmap access.
   <!-- Does this change introduce a new feature -->
   
   ### Generative AI tooling
   Generated-by: OpenAI Codex (GPT-6)
   <!--
   If generative AI tooling has been used in the process of authoring this 
patch, please include the
   phrase: 'Generated-by: ' followed by the name of the tool and its version.
   If no, write 'No'.
   Please refer to the [ASF Generative Tooling 
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to