JeonDaehong commented on code in PR #1390:
URL: https://github.com/apache/paimon-rust/pull/1390#discussion_r4550411664


##########
crates/paimon/src/table/sort_merge.rs:
##########
@@ -1897,6 +1916,93 @@ mod tests {
     use std::collections::HashMap;
     use std::sync::Arc;
 
+    #[tokio::test]
+    async fn pending_output_releases_unreferenced_source_batches() {

Review Comment:
   The lookup path (`changelog-producer = lookup`) also pushes a one-row batch 
for a key without a base row, and when that key's result is omitted nothing 
references it afterwards. With this change those get reclaimed too, where main 
kept them for as long as output rows were pending. Could a case with a 
`LookupProvider` cover that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to