taoran92 commented on code in PR #11129:
URL: https://github.com/apache/paimon/pull/11129#discussion_r4562749033


##########
paimon-core/src/main/java/org/apache/paimon/operation/WriteRestore.java:
##########
@@ -26,17 +26,24 @@
 
 import java.util.List;
 
-/** Restore for write to restore data files by partition and bucket from file 
system. */
+/** Restores data file metadata and indexes for write initialization. */
 public interface WriteRestore {
 
     long latestCommittedIdentifier(String user);
 
+    /**
+     * Restores the requested metadata for a partition and bucket.
+     *
+     * @param scanDataFileMetas whether to scan data manifests for data file 
metadata and the total
+     *     bucket count. Index restoration is independent of this flag.
+     */
     RestoreFiles restoreFiles(
             BinaryRow partition,
             int bucket,
             boolean scanDynamicBucketIndex,
             boolean scanDeleteVectorsIndex,
-            boolean scanSourceIndexPayloads);
+            boolean scanSourceIndexPayloads,
+            boolean scanDataFileMetas);

Review Comment:
   @JingsongLi thanks for reviewing! I have restored the five-argument overload 
and added a default bridge for compatibility, with regression tests for legacy 
wrappers. PTAL.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to