utafrali commented on code in PR #11166:
URL: https://github.com/apache/paimon/pull/11166#discussion_r4578567627
##########
paimon-core/src/main/java/org/apache/paimon/mergetree/compact/LookupMergeFunction.java:
##########
@@ -33,9 +33,13 @@
import java.util.List;
/**
- * A {@link MergeFunction} for lookup, this wrapper only considers the latest
high level record,
- * because each merge will query the old merged record, so the latest high
level record should be
- * the final merged value.
+ * A {@link MergeFunction} wrapper for lookup compaction.
+ *
+ * <p>{@link #getResult()} feeds the wrapped merge function with every
candidate whose {@code
+ * level() <= 0} (for example write-buffer records at level -1 and level-0
files), together with the
+ * high-level record chosen by {@link #pickHighLevel()} when one exists (the
lowest level among
Review Comment:
The phrase "for example write-buffer records at level -1 and level-0 files"
after `level() <= 0` reads as if there are other possible values, but those are
the only two cases. Using "namely" or "i.e." would be more precise:
```java
* level() <= 0} (i.e., write-buffer records at level -1 and level-0 files)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]