jackylee-ch opened a new pull request, #1414:
URL: https://github.com/apache/paimon-rust/pull/1414

   ### Purpose
   
   Linked issue: N/A (bug fix)
   
   `to_incremental_arrow` in Delta and Changelog mode returns the stored 
managed BLOB descriptors of a primary-key table instead of the payloads. An 
ordinary read and `to_audit_log_arrow` already resolve them, so the three reads 
of one table disagree.
   
   ### Brief change log
   
   - Route primary-key tables in `PaimonTableRead::to_incremental_arrow` 
through the same BLOB resolution as an ordinary primary-key read.
   - Factor the resolution out of `read_pk_with_blob` into 
`resolving_primary_key_blobs`, which takes the raw read as a closure. 
`read_pk_with_blob` keeps its behavior.
   - Tables without a primary key keep the existing raw read.
   
   ### Tests
   
   - Added `incremental_read_resolves_primary_key_blob_payloads` in 
`incremental_batch_scan_test.rs`: a primary-key table with a `BLOB` column and 
two writes; both `to_incremental_arrow` and `to_audit_log_arrow` must return 
the payloads. It fails on `main` (descriptor bytes come back) and passes with 
this change.
   - `cargo test -p paimon --test incremental_batch_scan_test` and `cargo test 
-p paimon --lib` pass; `cargo fmt --check` and `cargo clippy -p paimon 
--all-targets -- -D warnings` are clean.
   
   ### API and Format
   
   No API or storage format change.
   
   ### Documentation
   
   No documentation change.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to