Akash3121 commented on code in PR #11199:
URL: https://github.com/apache/paimon/pull/11199#discussion_r4589631014


##########
paimon-python/pypaimon/tests/s3_client_compatibility_test.py:
##########
@@ -270,7 +270,7 @@ def test_worker_recomputes_pyarrow_version(self):
             restored.__setstate__(state)
 
         version = parse(pyarrow.__version__)
-        self.assertEqual(version >= parse("8.0.0"), restored._pyarrow_gte_8)
+        self.assertEqual(version >= parse("10.0.0"), restored._pyarrow_gte_10)
         self.assertEqual(version >= parse("16.0.0"), restored._pyarrow_gte_16)
         self.assertEqual(version < parse("16.0.0"), 
restored._oss_bucket_in_endpoint)

Review Comment:
   Since CI resolves `pyarrow>=7,<13` on Python 3.7 to PyArrow 12.x and does 
not run PyArrow 8 or 9 directly, could we also add a version-boundary test 
(similar to `test_checksum_default_version_boundary`) covering `"8.0.0"`, 
`"9.0.0"`, and `"10.0.0"`?
    
    For example, mocking `pyarrow.__version__` (and deleting 
`AwsStandardS3RetryStrategy` on `< 10.0.0` via `mock.patch.object(pafs, 
"AwsStandardS3RetryStrategy", side_effect=AttributeError, create=True)`) and 
asserting that `S3FileSystem` is called without `request_timeout`, 
`connect_timeout`, or `retry_strategy` on `8.0.0`/`9.0.0`, and with them on 
`10.0.0` for both `s3` and legacy `oss`.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to