JingsongLi commented on PR #1417:
URL: https://github.com/apache/paimon-rust/pull/1417#issuecomment-6936259192

   Requirement fit: SUPPORTED. Implementation: FINDINGS at 6c92a1b9.
   
   The replay/uncertain-publication fix has clear end-to-end value. Local 
validation in an isolated worktree with Rust 1.98.0: all 216 existing 
table-commit tests, the OSS conditional-PUT replay test, and all 6 
write/overwrite recovery integration tests pass. Formatting/diff checks pass on 
the submitted tree, current-head CI is green, and the branch merges cleanly 
with current main.
   
   Extending the new rollback/cache fixture with an ordinary public table read 
exposes a remaining recovery defect: commit_compact succeeds, but the 
committing client's cached snapshot still exposes a rolled-back row that a 
fresh client correctly excludes. Details and repair direction are inline. Live 
OSS/STS behavior was not exercised.
   
   [P1] Refresh the shared snapshot cache before accepting replay success
   
   In the interleaving covered by 
`compact_replayed_publication_ignores_snapshot_cached_before_rollback`, the 
table first caches another writer's snapshot N; a separate client rolls it back 
and republishes our compact snapshot at N. `get_snapshot_uncached()` sees our 
UUID, but `InputFile::without_cache()` only bypasses the cache for that one 
read. It neither evicts nor refreshes the shared cached snapshot. This new 
success branch therefore makes `commit_compact()` return successfully while 
ordinary reads still use the rolled-back APPEND snapshot.
   
   I extended that existing fixture after `outcome.unwrap()`: the committing 
table's `get_latest_snapshot().uuid()` differs from 
`storage.get_snapshot(N).uuid()`. A public filtered read of `id=4000` with 
`deletion-vectors.merge-on-read=true` returns 0 rows through a fresh uncached 
Table, but 1 row through the committing Table, although both read the same 
location after successful recovery. Both probes fail on this head; the original 
fixture only checks DV survival through the uncached snapshot.
   
   Please invalidate or refresh the verified snapshot path in the shared cache 
before returning success, and cover ordinary table reads after rollback/replay, 
in addition to the uncached ownership and DV checks.
   
   Location: 
[`crates/paimon/src/table/table_commit.rs:1439`](https://github.com/apache/paimon-rust/blob/6c92a1b974b47dd834221b0d54849209b9a16d19/crates/paimon/src/table/table_commit.rs#L1439).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to