lyne7-sc opened a new pull request, #1437:
URL: https://github.com/apache/paimon-rust/pull/1437

   <!--
   Thank you very much for contributing to Paimon Rust - we are happy that you 
want to help us improve it. To help the community review your contribution in 
the best possible way, please go through the checklist below, which will get 
the contribution into a shape in which it can be best reviewed.
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GitHub 
issue](https://github.com/apache/paimon-rust/issues). Exceptions are made for 
typos in documentation or comments, which need no issue.
   
     - Fill out the template below to describe the changes contributed by the 
pull request. That will give reviewers the context they need to do the review.
   
     - Make sure that the change passes the automated tests, i.e., `cargo test` 
passes.
   
     - Each pull request should address only one issue, not mix up code from 
multiple issues.
   
   **(The sections below can be removed for hotfixes or typos)**
   -->
   
   ### Purpose
   
   <!-- Linking this pull request to the issue -->
   Linked issue: close #1436
   
   <!-- What is the purpose of the change -->
   
   `CREATE TABLE t (id INT PRIMARY KEY)` currently creates a Paimon schema 
without a primary key because only table-level constraints are read. Honor 
column-level declarations so they produce the same schema as `PRIMARY KEY (id)`.
   
   ### Brief change log
   
   <!-- Please describe the changes made in this pull request and explain how 
they address the issue -->
   
   - Extract column-level and table-level primary keys with consistent 
identifier normalization.
   - Reject multiple primary-key declarations instead of ignoring column-level 
declarations or letting the last table-level declaration win. Preserve 
composite primary keys.
   
   ### Tests
   
   <!-- List unit tests or integration cases to verify this change -->
   
   - `test_create_table_column_primary_key` checks that inline and table-level 
declarations produce matching primary keys and fields for unquoted and quoted 
identifiers.
   - `test_create_table_composite_primary_key` preserves composite-key order.
   - `test_create_table_rejects_multiple_primary_keys` checks conflicting 
declarations fail before catalog creation.
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   
   No public API or storage format changes.
   
   ### Documentation
   
   <!-- Does this change introduce a new feature or require documentation 
updates -->
   
   No documentation changes are required.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to