JingsongLi commented on PR #11207:
URL: https://github.com/apache/paimon/pull/11207#issuecomment-6951812128

   Requirement fit: PIVOT to regression-test coverage. Implementation: no new 
correctness defect found, but this branch currently conflicts with master.
   
   The production fix has already landed in #11217 
(9aee53de09cdf090ada82b48dd79001a41097243). Current master checks every 
distinct producing schema in the max-level run before skipping full compaction, 
which is equivalent to the production change here. A three-way merge against 
current master 2bf10c194b confirms a content conflict in 
IncrementalClusterStrategy.java.
   
   The three real-table regression cases here still add useful coverage beyond 
#11217's strategy unit test: actual schema alteration, both file orders, 
combined pending messages, compaction/commit/read and the compression-only 
no-rewrite control. I reran the 19 selected tests on this PR head with JDK 11 
and normal Maven checks, then transplanted only this regression test class onto 
an isolated current-master worktree. The real-table cases also pass there 
without this PR's production change.
   
   Please rebase onto current master, drop the repeated production hunk, keep 
the real-table regressions, and update the title/purpose to describe the 
additional coverage. That preserves the useful end-to-end tests while avoiding 
a duplicate fix. I am leaving this PR open for that adjustment.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to