LsomeYeah opened a new pull request, #11239: URL: https://github.com/apache/paimon/pull/11239
### Purpose The Spark `sys.compact` procedure currently accepts dynamic table options only as a comma-separated `options` string. This cannot preserve values containing commas, for example multiple classes in `commit.callbacks`. Add an optional `options_map MAP<STRING, STRING>` argument, following the existing `migrate_table` and `migrate_database` procedures. It is appended after all existing arguments to preserve positional-call compatibility. Legacy `options` are parsed first, and `options_map` overrides duplicate keys. Both continue to use the existing invocation-local `table.copy(dynamicOptions)` path without modifying stored table properties. Document the argument, precedence, and a comma-containing callback example. No changes are made to the legacy parser or other procedures. ### Tests Added three Spark SQL integration cases covering legacy positional arguments, two comma-separated callbacks actually receiving a COMPACT commit, and map-over-string precedence. Every case also verifies unchanged stored schema options and preserved table contents. - JDK 8 / Spark 3.5.9: `CompactOptionsMapTest`, 3/3 passed; reactor `test` succeeded. - JDK 17 / Spark 4.1.4: `CompactOptionsMapTest`, 3/3 passed; reactor `clean package` succeeded. - `spotless:check`, `checkstyle:check`, and `git diff --check` passed. Broader verification limitation: the existing Spark 3.5 `CompactProcedureTest` passed 33 cases before stopping in its local-sort test on a Parquet linkage mismatch (`NoSuchMethodError: ParquetFileReader.open(InputFile, ParquetReadOptions)`) in the unbundled reactor test classpath. That run was terminated; the full existing suite is not claimed as passing. This PR does not change Parquet classes or dependencies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
