dragonknightk commented on code in PR #11178:
URL: https://github.com/apache/paimon/pull/11178#discussion_r4611511143
##########
paimon-core/src/main/java/org/apache/paimon/mergetree/compact/PartialUpdateMergeFunction.java:
##########
@@ -206,8 +206,9 @@ public void add(KeyValue kv) {
}
if (removeRecordOnDelete) {
+ // -U also removes the row, a later +I or +U restores it
+ currentDeleteRow = true;
Review Comment:
Thanks for the detailed repro. The Rust side is fixed in
apache/paimon-rust#1434, which is merged and will ship in pypaimon-rust 0.6.0.
I tried the explicit rejection route locally. Before 0.6.0, the Native
reader, the Native writer and a table source of Native MERGE INTO can all raise
a clear error for these tables. SQL is the gap: PyPaimon passes the whole
statement to pypaimon-rust, which parses it and resolves the tables itself, so
PyPaimon cannot tell which tables a query touches. Before 0.6.0, SQL queries
would still return the stale row, and SQL writes would persist it.
So I'd prefer to wait for pypaimon-rust 0.6.0, raise the minimum version
here, and merge this PR then. That covers every path at once and avoids a guard
we would remove later. (๑•̀ㅂ•́)و✧
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]