SteNicholas commented on code in PR #576:
URL: https://github.com/apache/paimon-cpp/pull/576#discussion_r4620842497


##########
include/paimon/defs.h:
##########
@@ -247,6 +247,11 @@ struct PAIMON_EXPORT Options {
     /// The default value is 1024.
     static const char READ_BATCH_SIZE[];
 
+    /// "read.preparation-window" - Maximum number of data-file reader stacks 
retained per
+    /// append/raw split, including in-flight builds. Accepts positive 32-bit 
integers; defaults
+    /// to 4. Independent of reader-build executor parallelism, batch prefetch 
and warmup settings.
+    static const char READ_PREPARATION_WINDOW[];

Review Comment:
   Marked `read.preparation-window` as C++-specific in the public option 
comment and the prefetch guide. The guide also shows how to set it with 
`ReadContextBuilder::AddOption`. [Option 
declaration](https://github.com/apache/paimon-cpp/blob/ebe1e01b34628cff5c3893719e4b0af889f147d9/include/paimon/defs.h#L250-L253)
   



##########
src/paimon/common/reader/concat_batch_reader.cpp:
##########


Review Comment:
   `CreateLazy` now validates its inputs and prepares the shared factory state 
before calling the private constructor. The constructor initializes the reader 
count, window, pool and executor before the first build is submitted. 
[Implementation](https://github.com/apache/paimon-cpp/blob/ebe1e01b34628cff5c3893719e4b0af889f147d9/src/paimon/common/reader/concat_batch_reader.cpp#L48-L80)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to