JingsongLi commented on code in PR #11205:
URL: https://github.com/apache/paimon/pull/11205#discussion_r4624188662
##########
paimon-core/src/main/java/org/apache/paimon/table/sink/CommitMessageSerializer.java:
##########
@@ -127,6 +127,19 @@ private void serialize(CommitMessage obj, DataOutputView
view) throws IOExceptio
if (checkFromSnapshot != null) {
view.writeLong(checkFromSnapshot);
}
+ String generation = message.deleteOrderingGuardGeneration();
Review Comment:
[P2] Unconditionally writing v16 breaks the documented Java-to-Native
commit-message handoff even when guard fields are absent. I prepared a real
fixed-bucket append in Java with each build and passed the serialized messages
to released `pypaimon-rust` 0.5.0. The baseline v14 message decoded and
committed, and the snapshot was visible. The v16 message failed with
`serializer version 16 is not supported`; passing the new body as v14 also
failed with `2 trailing bytes after CommitMessage`. Current Rust still
documents and supports [only the Java v14
body](https://github.com/apache/paimon-rust/blob/9247ad821d6c8ddca2b1788789729a31400c748d/bindings/python/README.md#L507-L514).
Please preserve the v14 handoff for unguarded messages (with its actual
negotiated version), or coordinate the Rust reader and document the required
upgrade before switching the default writer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]