JingsongLi commented on code in PR #11245:
URL: https://github.com/apache/paimon/pull/11245#discussion_r4624971904


##########
paimon-api/src/main/java/org/apache/paimon/CoreOptions.java:
##########
@@ -5134,20 +5134,33 @@ public boolean withVectorFormat() {
         return options.contains(VECTOR_FILE_FORMAT);
     }
 
-    public Set<String> vectorField() {
-        String vectorFields = options.get(CoreOptions.VECTOR_FIELD);
-        if (vectorFields == null || vectorFields.trim().isEmpty()) {
-            return Collections.emptySet();
-        }
-        return 
Arrays.stream(vectorFields.trim().split(",")).collect(Collectors.toSet());
+    /** Resolves {@link #VECTOR_FIELD} against the given field names. */
+    public Set<String> vectorField(List<String> fieldNames) {

Review Comment:
   **[P2] Keep the published vector-field overloads callable**
   
   Paimon 2.0.0 exposes both `CoreOptions.vectorField()` and 
`CoreOptions.vectorField(Map)`. I compiled an unchanged Java caller against the 
pre-change API. It printed `[embedding]` for both calls on that build, then 
failed with `NoSuchMethodError` at the first call when loaded with this PR's 
API. Trimming in the built-in catalogs does not require removing either entry 
point. Keep both overloads with their legacy parsing semantics, deprecate them 
if desired, and use the schema-aware overloads inside Paimon.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to