lxy-9602 commented on code in PR #580:
URL: https://github.com/apache/paimon-cpp/pull/580#discussion_r4626532262


##########
cmake_modules/arrow_geospatial.diff:
##########
@@ -0,0 +1,1384 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the

Review Comment:
   Before the review, I think a patch of this large scale (feature-oriented) 
may not be appropriate. I would recommend rather first upgrade the Arrow 
version to >21. While, before that, we need performance testing to ensure the 
new Arrow version doesn’t introduce any performance regression. @lucasfang What 
do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to