JingsongLi commented on code in PR #1454:
URL: https://github.com/apache/paimon-rust/pull/1454#discussion_r4643280347


##########
crates/paimon/src/table/table_commit.rs:
##########
@@ -2252,6 +2266,10 @@ impl TableCommit {
                         },
                     )
                     .await?;
+                if let Some((captured, latest)) = dv_snapshots {
+                    self.check_dv_compaction_history(captured, latest, entries)

Review Comment:
   **[P2] Reclaim automatic compaction outputs after a definite rejection**
   
   In 
`overwrite_recovery_after_cas_loss_refreshes_dv_and_preserves_append_changelog`,
 the publisher definitively returns `Ok(false)` for the first automatic 
COMPACT. The retried commit then hits this history rejection, and auto 
maintenance drops its prepared output paths. I recorded the ADD file from that 
rejected snapshot's delta manifest. After recovery succeeded, the file was 
absent from the active manifest and still present in `bucket-0`.
   
   Repeated races can accumulate one set of abandoned data and sidecar files 
per failed attempt until orphan cleanup. Keep ownership of automatic outputs 
and reclaim them on definite nonpublication. Preserve them when publication has 
an unknown outcome.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to