lxy-9602 commented on code in PR #583: URL: https://github.com/apache/paimon-cpp/pull/583#discussion_r4651762145
########## src/paimon/indexer/lumina/lumina_realtime_index.cpp: ########## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#include "paimon/indexer/lumina/lumina_realtime_index.h" + +#include <algorithm> +#include <cmath> +#include <limits> +#include <map> +#include <string> +#include <utility> +#include <vector> + +#include "arrow/api.h" +#include "arrow/c/bridge.h" +#include "lumina/core/Constants.h" +#include "paimon/common/utils/arrow/status_utils.h" +#include "paimon/common/utils/checked_cast.h" +#include "paimon/common/utils/options_utils.h" +#include "paimon/core/realtime/realtime_utils.h" +#include "paimon/indexer/lumina/lumina_memory_pool.h" +#include "paimon/indexer/lumina/lumina_utils.h" + +namespace paimon::lumina { + +LuminaRealtimeIndex::LuminaRealtimeIndex( + std::shared_ptr<arrow::Schema> schema, LuminaIndexInfo index_info, + std::unique_ptr<::lumina::extensions::StreamWithFilterExtension> filter, + std::unique_ptr<::lumina::api::LuminaStreamer> streamer, std::unique_ptr<LuminaMemoryPool> pool) + : schema_(std::move(schema)), + index_info_(std::move(index_info)), + pool_(std::move(pool)), + filter_(std::move(filter)), + streamer_(std::move(streamer)) {} + +LuminaRealtimeIndex::~LuminaRealtimeIndex() = default; + +Result<std::shared_ptr<LuminaRealtimeIndex>> LuminaRealtimeIndex::Create( + const std::shared_ptr<arrow::Schema>& schema, const std::map<std::string, std::string>& options, + const std::shared_ptr<MemoryPool>& pool) { + if (!pool) { + return Status::Invalid("Lumina realtime index requires a memory pool"); + } + PAIMON_RETURN_NOT_OK(RealtimeUtils::ValidateOffsetField(schema)); + if (schema->num_fields() != 2 || schema->field(1)->type()->id() != arrow::Type::LIST || + checked_pointer_cast<arrow::ListType>(schema->field(1)->type())->value_type()->id() != + arrow::Type::FLOAT) { + return Status::Invalid("Lumina realtime index requires [offset, LIST<FLOAT>]"); + } + const std::map<std::string, std::string> lumina_options = + OptionsUtils::FetchOptionsWithPrefix(LuminaDefines::kOptionKeyPrefix, options); + if (lumina_options.count(std::string(::lumina::core::kExtensionTagSchema))) { + return Status::NotImplemented("Lumina realtime tags are not supported"); + } + PAIMON_ASSIGN_OR_RAISE(LuminaIndexInfo info, LuminaIndexOptions::GetIndexInfo(lumina_options)); + PAIMON_ASSIGN_OR_RAISE(::lumina::api::StreamerOptions streamer_options, + LuminaIndexOptions::CreateStreamerOptions(lumina_options)); + auto lumina_pool = std::make_unique<LuminaMemoryPool>(/*track_memory=*/true, pool); + auto filter = std::make_unique<::lumina::extensions::StreamWithFilterExtension>(); + PAIMON_ASSIGN_OR_RAISE_FROM_LUMINA( + ::lumina::api::LuminaStreamer native_streamer, + ::lumina::api::LuminaStreamer::Create( + streamer_options, ::lumina::core::MemoryResourceConfig(lumina_pool.get()))); + auto streamer = std::make_unique<::lumina::api::LuminaStreamer>(std::move(native_streamer)); + PAIMON_RETURN_NOT_OK_FROM_LUMINA(streamer->Attach(*filter)); + return std::shared_ptr<LuminaRealtimeIndex>(new LuminaRealtimeIndex( + schema, std::move(info), std::move(filter), std::move(streamer), std::move(lumina_pool))); +} + +Status LuminaRealtimeIndex::AddBatch(::ArrowArray* batch) { + if (!batch || !batch->release) { + return Status::Invalid("Lumina realtime batch is null or released"); + } + PAIMON_ASSIGN_OR_RAISE_FROM_ARROW(std::shared_ptr<arrow::Array> imported, + arrow::ImportArray(batch, arrow::struct_(schema_->fields()))); + if (write_failed_) { + return Status::Invalid("Lumina realtime index cannot write after an insertion failure"); + } + PAIMON_RETURN_NOT_OK_FROM_ARROW(imported->ValidateFull()); + const auto data = checked_pointer_cast<arrow::StructArray>(imported); + const auto offsets = checked_pointer_cast<arrow::Int64Array>(data->field(0)); + const auto vectors = checked_pointer_cast<arrow::ListArray>(data->field(1)); + const auto values = checked_pointer_cast<arrow::FloatArray>(vectors->values()); + if (data->null_count() != 0 || offsets->null_count() != 0) { + return Status::Invalid("Lumina realtime rows and offsets must not be null"); + } + for (int64_t row = 0; row < data->length(); ++row) { + if (vectors->IsNull(row)) { + continue; + } + if (vectors->value_length(row) != static_cast<int64_t>(index_info_.dimension)) { + return Status::Invalid("Lumina realtime vector dimension mismatch"); + } + for (int64_t pos = vectors->value_offset(row); pos < vectors->value_offset(row + 1); + ++pos) { + if (values->IsNull(pos) || !std::isfinite(values->Value(pos))) { + return Status::Invalid( + "Lumina realtime vector elements must be finite non-null floats"); + } + } + } + for (int64_t row = 0; row < data->length(); ++row) { + if (vectors->IsNull(row)) { + continue; + } + const Status status = LuminaToPaimonStatus(streamer_->Insert( Review Comment: This is a Lumina-specific index implementation, and Paimon shouldn’t be aware of it. Upstream users need to seal/prepare commit in advance if they use lumina (They need to understand based on Lumina’s documentation. Just like Paimon shouldn’t be aware of Lumina’s specific configuration items.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
