lxy-9602 opened a new pull request, #585:
URL: https://github.com/apache/paimon-cpp/pull/585

   …ction
   
   <!-- PR titles must follow Conventional Commits: <type>(<optional-scope>): 
<description> -->
   
   ### Purpose
   
   <!-- Linking this pull request to the issue -->
   Linked issue: close #571 
   
   Move custom file compaction out of the public `FileStoreWrite` interface 
into `AppendFileCompaction::PrepareCommit`.
   
   Each call creates a dedicated batch writer, restores the latest snapshot, 
compacts the selected files, and closes the writer before returning commit 
messages. Callers commit or abort these messages through `FileStoreCommit`.
   
   Reuse the existing append writer and compaction manager while removing the 
state flags and guards that prevent mixing custom compaction with regular 
writes.
   
   <!-- What is the purpose of the change -->
   
   ### Tests
   - Migrate custom compaction tests to the new API.
   - Cover invalid inputs and unsupported table configurations.
   - Verify returned files survive writer closure and can be aborted.
   - Verify a subsequent call restores newly committed files, merges two files, 
and produces messages that can be committed.
   - Retain integration coverage for non-contiguous inputs, deletion vectors, 
fully deleted files, and query results after commit.
   
   <!--
   Describe tests added or updated and what they cover; explain if no test 
changes are needed.
   Omit execution commands, results, and reasons tests were not run locally.
   -->
   
   ### API and Format
   Replace public `FileStoreWrite::CompactFiles` with 
`AppendFileCompaction::PrepareCommit`. Existing callers must migrate to the new 
synchronous API.
   
   No storage format or protocol changes.
   
   <!-- Does this change affect API in include dir or storage format or 
protocol -->
   
   ### Documentation
   Update the write API reference and custom compaction guide with the new API 
and lifecycle.
   
   Clarify that compactions within the same partition/bucket must be serialized 
when deletion vectors are enabled. Without deletion vectors, compactions with 
disjoint inputs may run concurrently.
   
   <!-- Does this change introduce a new feature -->
   
   ### Generative AI tooling
   Generated-by: OpenAI Codex (GPT-6)
   <!--
   If generative AI tooling has been used in the process of authoring this 
patch, please include the
   phrase: 'Generated-by: ' followed by the name of the tool and its version.
   If no, write 'No'.
   Please refer to the [ASF Generative Tooling 
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to