zhangyue19921010 opened a new pull request, #11336:
URL: https://github.com/apache/paimon/pull/11336

   ### Purpose
   
   Fixes #11335.
   
   Report failed directory deletion when dropping a filesystem catalog table. 
`FileIO.delete` can return `false`, including when local directory permissions 
prevent deletion; the catalog currently returns normally even though the table 
remains loadable.
   
   Check for a remaining directory after a false result and fail with its path. 
Missing directories remain harmless, and a failed table-directory deletion 
stops before external-directory cleanup.
   
   ### Tests
   
   Added public catalog regressions for failed table/external directory 
deletion with both `ignoreIfNotExists` values, missing external paths and 
concurrent removal. A real POSIX read-only schema-directory case reproduces the 
problem without a mocked FileIO; it restores permissions in `finally` and is 
skipped where the permission restriction cannot be enforced.
   
   Baseline: five failures and two passing controls, with no skips on this 
host. Final verification: 15 tests passed with no skips, including existing 
filesystem table-drop cases. Ran `mvn -pl paimon-core -am -DfailIfNoTests=false 
-DwildcardSuites=none 
-Dtest=FileSystemCatalogDeleteFailureTest,FileSystemCatalogTest#testDropTable*+testDropNonDataTablePreservesExternalPaths
 test` on JDK 11 after packaging the codegen-loader prerequisite. Checkstyle, 
Spotless and Enforcer passed without `fast-build`; `mvn -N apache-rat:check` 
passed separately.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to