SteNicholas commented on code in PR #1487:
URL: https://github.com/apache/paimon-rust/pull/1487#discussion_r4656339283


##########
crates/paimon/src/table/de_vector_read/tests.rs:
##########
@@ -918,34 +923,46 @@ fn 
test_collect_raw_batch_vector_batch_scores_only_include_row_ids() {
         ],
     )
     .unwrap();
-    let mut include_row_ids = RoaringTreemap::new();
-    include_row_ids.insert(12);
-    let searches = vec![
-        VectorSearch::new(vec![1.0, 0.0], 2, "embedding".to_string())
-            .unwrap()
-            .with_include_row_ids(include_row_ids),
-    ];
-    let scoring_plan = RawScoringPlan::new(&searches, RawVectorMetric::L2);
-    let mut top_k = searches
-        .iter()
-        .map(|search| RawScoreTopK::new(search.limit))
-        .collect::<Vec<_>>();
-
-    collect_raw_batch_vector_batch(
-        &batch,
-        &searches,
-        RawVectorMetric::L2,
-        &scoring_plan,
-        &mut top_k,
-    )
-    .unwrap();
-    let results = top_k
-        .into_iter()
-        .map(RawScoreTopK::into_search_result)
-        .collect::<Vec<_>>();
+    let shared_include: Arc<RoaringTreemap> = 
Arc::new(std::iter::once(12).collect());
+    for (included, shared) in [([12, 12], true), ([12, 11], false)] {

Review Comment:
   **Both cases exclude row 10, so the test can pass if a selected row with a 
null coordinate is silently dropped.** I changed the collector locally to 
continue on a coordinate-validation error. All 56 existing `de_vector_read` 
tests still passed. Please add a case where one query selects row 12 and 
another selects row 10, and assert that the batch returns `DataInvalid` for the 
null vector element. Pairing the row-12 filter with an unrestricted query 
should produce the same error and exercise `all_query_indices`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to