JingsongLi commented on code in PR #1476:
URL: https://github.com/apache/paimon-rust/pull/1476#discussion_r4656356333
##########
bindings/c/src/write.rs:
##########
@@ -646,6 +646,31 @@ pub unsafe extern "C" fn
paimon_table_write_write_arrow_batch(
tw: *mut paimon_table_write,
array: *mut c_void,
schema: *mut c_void,
+) -> *mut paimon_error {
+ write_arrow_batch(tw, array, schema, None)
+}
+
+/// Write a batch whose rows all belong to the supplied bucket and a single
partition.
Review Comment:
**[P2] Specify which table modes accept precomputed bucket IDs**
The new router accepts `bucket=-2` and returns positive bucket IDs with an
explicit partition plan. The precomputed write API rejects those IDs on the
same table. I routed two partitions with counts 1 and 3, got `[0, 2]`, and
passed `2` to this function for the second partition. It returned `Precomputed
bucket writes are only valid for HASH_FIXED or HASH_DYNAMIC tables`. The
dedicated postpone writer committed both groups to the expected buckets with
the same plan and recalculated the bucket IDs itself.
Please document the mode restriction here and link the postpone routing docs
to the dedicated writer and its shared-plan setup. If postpone is meant to
support the advertised precomputed write flow, that writer needs an entry point
that accepts the supplied bucket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]