SteNicholas commented on PR #1447:
URL: https://github.com/apache/paimon-rust/pull/1447#issuecomment-7079809959

   @JingsongLi, I took your suggestion to limit new definitions in e24e33b1. 
The filesystem and REST catalogs now reject generated columns on `CREATE` 
because Rust cannot yet type-check their expressions. Rust can still read a 
Java-created table and preserve its `generationExpression` through a compatible 
`ALTER`.
   
   With your `source INT` and `generated STRING AS source` example, 
`create_table` now returns `Error::Unsupported` before writing schema version 
0. The regression also checks a matching `INT` declaration, so both cases stay 
covered until type checking is available. [Original 
review](https://github.com/apache/paimon-rust/pull/1447#pullrequestreview-5993842224)
 ยท [Regression 
test](https://github.com/SteNicholas/paimon-rust/blob/e24e33b1aa1b3f3e4c178db7d0d173a6d5e2c95f/crates/paimon/src/catalog/filesystem.rs#L2458-L2503)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to