Fokko commented on code in PR #1192:
URL: https://github.com/apache/parquet-mr/pull/1192#discussion_r1437675879
##########
parquet-thrift/src/main/java/org/apache/parquet/thrift/ThriftSchemaConverter.java:
##########
@@ -225,14 +225,18 @@ private static ThriftField toThriftField(String name,
Field field, ThriftField.R
final Field listElemField = field.getListElemField();
type = new ThriftType.ListType(toThriftField(listElemField.getName(),
listElemField, requirement));
break;
+ case UUID:
case ENUM:
- Collection<TEnum> enumValues = field.getEnumValues();
- List<EnumValue> values = new ArrayList<ThriftType.EnumValue>();
- for (TEnum tEnum : enumValues) {
- values.add(new EnumValue(tEnum.getValue(), tEnum.toString()));
+ if (field.isEnum()) {
Review Comment:
It looks like there are still enums with field-id 16. It can be that they
are using an old Java SDK. This was a reliable way do differentiate between
them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
