steveloughran commented on code in PR #1244:
URL: https://github.com/apache/parquet-mr/pull/1244#discussion_r1439075748
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetOutputCommitter.java:
##########
@@ -20,30 +20,46 @@
import java.io.IOException;
import java.util.List;
+import org.apache.hadoop.classification.InterfaceAudience;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.FileStatus;
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.fs.Path;
import org.apache.hadoop.mapreduce.JobContext;
+import org.apache.hadoop.mapreduce.JobStatus;
import org.apache.hadoop.mapreduce.TaskAttemptContext;
import org.apache.hadoop.mapreduce.lib.output.FileOutputCommitter;
+import org.apache.hadoop.mapreduce.lib.output.PathOutputCommitterFactory;
import org.apache.parquet.hadoop.ParquetOutputFormat.JobSummaryLevel;
import org.apache.parquet.hadoop.util.ContextUtil;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+/**
+ * decorator class for PathOutputCommitter, for adding optional parquet
metadata file,
+ * overriding all methods to delegate to an instance of
<code>PathOutputCommitterFactory.getCommitterFactory(..)</code>
+ * <p>
+ * For internal reason (hard-coded 'instanceof FileOutputCommitter' in spark
source code),
+ * this class still temporarily <code>extends FileOutputCommitter</code>
instead of <code>PathOutputCommitter</code>
+ */
public class ParquetOutputCommitter extends FileOutputCommitter {
private static final Logger LOG =
LoggerFactory.getLogger(ParquetOutputCommitter.class);
private final Path outputPath;
+ private final FileOutputCommitter delegate;
Review Comment:
problem here is it's still an FOC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
